Skip to content

Quick fix for ATLASRECTS-5714

Stephen Nicholas Swatman requested to merge sswatman/athena:bugfix/ATLASRECTS-5714 into master

Ticket ATLASRECTS-5714 describes a performance regression by my earlier merge request !37151 (merged). The earlier merge request returns a false value in various places that are at risk of using incorrectly initialized covariance matrices. This most likely caused some computations to be run multiple times, leading to a performance regression. This commit changes the return value in these cases from false to true, ensuring that the invalid covariances are not propagated, while also ensuring that the CPU performance stays the same.

Closes ATLASRECTS-5714.

After this, further investigation is still warranted as mentioned in the Jira ticket.

Merge request reports