Skip to content

TEvent::fill() Fix, 21.2 branch (2020.10.19.)

Attila Krasznahorkay requested to merge akraszna/athena:TEventFillFix-21.2-20201019 into 21.2

Fixed a logic error in xAOD::TEvent::fill(), following the very insightful analysis of @robouque in ATLASG-1555.

The loop over xAOD::TEvent::m_outputObjects inside the xAOD::TEvent::fill() function was unsafe so far. Since the loop could add new elements to the container itself. Making the loop miss some elements of the container.

This is meant to fix the issue described in ATLASG-1555.

I'm adding the full-unit-tests label, just to be safe. However I would be extremely surprised if this would make anything worse. At most it may uncover some other dormant issues... 😛

Merge request reports