Skip to content
Snippets Groups Projects

21.9: Porting changes to fast clusterisation (as done in master) to profit of it by default.

Merged Noemi Calace requested to merge ncalace/athena:21.9-updating-clustering into 21.9
All threads resolved!

Since I have updated the version for master (!36138 (merged)), I think would be useful to back-port it for 21.9, so that we can run the fast pixel clustering while preserving the output.

Changes in the RunUpgradeTests.py as the pixel clusters are sorted differently in ESDs and AODs. I have run IDPVM to compare the cluster quantities after running RunUpgradeTests.py using reference and patched versions and the results are 1:1 identical: https://test-dcube.web.cern.ch/test-dcube/dcube_test_clustering/

Edited by Noemi Calace

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good, just minor comment, passing to L2 for a second opinion --L1

  • Do not see any additional problems here... @ncalace , could you answer the L1 comment ?

     Pavol [as L2 MR shifter]
  • Noemi Calace added 15 commits

    added 15 commits

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetRecTools/SiClusterizationTool

    Adding @goetz ,@oda ,@amorley ,@sroe as watchers

  • Noemi Calace resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash fb93dba1)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45077]

  • Nicholas Styles mentioned in commit 56e6d8eb

    mentioned in commit 56e6d8eb

  • Please register or sign in to reply
    Loading