Skip to content

cleanup of RpcCablingCondAlg

Walter Lampl requested to merge wlampl/athena:RPCCablingCondAlgCleanup into master

Addresses the issues I criticized in ATLASRECTS-5708:

  • Collapse the internal methods into one that is now const (do not pass data via member variables)
  • Query only the cool channels that we need instead of looping over all channels
  • Delete a lot of dead code. The current implementation loads some data from COOL, processes it a bit and then discards the result.

It would be really good if someone who understands the RPC Cabling could weigh in on this MR before it gets merged. As I said on ATLASRECTS-5708, it's possible that the migration from the old cabling tool to a cabling-conditions-algo is incomplete. It is conceivable that the data that the current implementation discards should be used.

I verified that the q431-ESD remains unchanged by this unchanged by the code-changes proposed here.

  • Walter

Merge request reports