Fix aliasing bug in newCovarianceMatrix method
The PatternTrackParameters
class conains a method by the name of
newCovarianceMatrix
which updates the covariance matrix of the object
it is called on according to the covariance matrix in a second set of
parameters and a Jacobian matrix. The calculation performed is JCJ^T.
In many cases where this method is called, the object on which it is
called is the same as the object given as the right hand side of the
operation. This means that the covariance matrices alias, leading to
possibly incorrect results. It also invites behaviour where the
calculations are done using invalid covariance matrices.
This commit fixes these issues by changing the signature of the method to accept a covariance matrix directly instead of a second set of track parameters. This makes it harder, albeit not impossible, to alias the covariance matrices as described earlier. It also solves the invalid covariance matrix problem described in !37151 (merged).
Merge request reports
Activity
added InnerDetector JetEtmiss Tracking master review-pending-level-1 labels
- Resolved by Christos Anastopoulos
✅ CI Result SUCCESS (hash 7a53e2b1)Athena AthSimulation AthGeneration AnalysisBase externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22135]added 1 commit
- b64418b1 - Fix aliasing bug in newCovarianceMatrix method
✅ CI Result SUCCESS (hash b64418b1)Athena AthSimulation AthGeneration AnalysisBase externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22151]added 1 commit
- c119a1a0 - Fix aliasing bug in newCovarianceMatrix method
✅ CI Result SUCCESS (hash c119a1a0)Athena AthSimulation AthGeneration AnalysisBase externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22208]added review-pending-level-2 label and removed review-pending-level-1 label
added review-approved label and removed review-pending-level-2 label
added review-user-action-required label and removed review-approved label
added 397 commits
-
c119a1a0...359a3dba - 396 commits from branch
atlas:master
- 8919d760 - Fix aliasing bug in newCovarianceMatrix method
-
c119a1a0...359a3dba - 396 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
✅ CI Result SUCCESS (hash 8919d760)Athena AthSimulation AthGeneration AnalysisBase externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22378]added review-approved label and removed review-pending-level-1 label
mentioned in commit c2300f44
added sweep:ignore label