RootCollection: cppcheck fixes

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.RootCollection-20201020 into master
  • Pass class instances by const reference, not by value.
  • Don't use string::find to test the start of a string.

Merge request reports