Pass context to newDecisionIn

pass EventContext to newDecisionIn method. The method has a default argument:

  Decision* newDecisionIn( DecisionContainer* dc, const Decision* dOld, const std::string& name = "", const EventContext& ctx = Gaudi::Hive::currentContext() );

so if the context isn't passed, it's looked up from currentContext().

This merge request affects 1 package:

• Trigger/TrigSteer/DecisionHandling

Adding @tamartin as watcher

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash b77b9385)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22203]

Hi @mh, could you comment why it is needed?

Hi @smh,

Your changes also seem to trigger a problem in the unit tests: Py:TriggerMenuMT.HLTMenuConfig.Menu.GenerateMenuMT DEBUG Finished with retrieving chain configuration for chain HLT_TestChain6_muv1_TestChain10_ev1_L1MU6_EM5 Py:Athena INFO leaving with code 8: "an unknown exception occurred" Could you please advise?

Cheers Nathan (L1)

added review-user-action-required label and removed review-pending-level-1 label

changed the description

Hi @tbold,

I made this clearer in the description.

I am a bit confused as to why the test is failing, but will investigate further.

OK actually this fails in the nightlies: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/GITWebArea/nightlies/master/2020-10-21T2101/Athena/x86_64-centos7-gcc8-opt/Athena/UT/DecisionHandling.log.html

added review-pending-level-1 label and removed review-user-action-required label

Looks good but can we retry the CI to see if the issue is gone?

Certainly we can, but it will fail in the same way. My MR is not meant to address this issue - it's discussed e.g. on !37075 (merged) but there is no fix yet

Ok, I don't see how that MR could be related with the crash since that one seems to addressing issues with multijet chains, but anyway, I'm happy to approve this one if urgently needed

Hi Edson,

My change touches DecisionHandling, which already had a failing unit test. So it doesn't matter if you rerun the CI, it will still fail. I linked to a discussion about it, although it is indeed off-topic from multi-jets.

The MR is not urgent but it doesn't make sense to wait until the unit test is fixed, since this is independent from my changes.

Cheers,

Stewart

Ok, no problem, I will mark this as approved then

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 359a3dba

added sweep:ignore label

I’m fixing the failure in !37618 (merged)

mentioned in merge request !49486 (closed)