Skip to content

GSF . clang-tidy checks. Including possible use after move bugfix

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:GaussianSumFilet_less_clone_TrackParameters into master

Perhaps the most importand is this

@@ -981,7 +984,8 @@ Trk::GaussianSumFitter::stepForwardFit(
     const Trk::MultiComponentStateOnSurface* multiComponentStateOnSurface =
       new MultiComponentStateOnSurface(
         measurement.release(),
-        Trk::MultiComponentStateHelpers::toPtr(std::move(extrapolatedState)).release(),
+        //used below for the updated state so clone
+        Trk::MultiComponentStateHelpers::clone(extrapolatedState).release(),

as was a possible use after move.

Edited by Christos Anastopoulos

Merge request reports