Skip to content
Snippets Groups Projects

Filling histograms of deltaPt for all matched jets in JetMonitoring

Merged Filling histograms of deltaPt for all matched jets in JetMonitoring
(removed):master-fixJetHistoMatchedFiller into master
All threads resolved!
Merged Ricardo Barrue requested to merge (removed):master-fixJetHistoMatchedFiller into master
All threads resolved!

Previously, jetHistoMatchFiller was filling the histograms of the difference in pT between matched jets, but only for the last matched pair in the event.

This MR fixes that, by filling the histograms of that quantity for all the matched jet pairs in an event.

Tagging @jbossios

Edited by Ricardo Barrue

Merge request reports

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Oct 28, 2020 3:21pm UTC)

Merge details

  • Changes merged into main with 898ec095 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ricardo Barrue added 1 commit

    added 1 commit

    • 258272be - Fixing filling of ptdiff variable

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 1 package:

    • Reconstruction/Jet/JetMonitoring

    Adding @goetz as watcher

  • Ricardo Barrue added 29 commits

    added 29 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 1 package:

    • Reconstruction/Jet/JetMonitoring

    Adding @goetz as watcher

  • Jonathan Bossio
  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 258272be)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22389]

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash ff00bc1f)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22390]

  • Mike Hance added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Ricardo Barrue added 104 commits

    added 104 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 1 file:

    • Reconstruction/Jet/JetMonitoring/src/JetHistoMatchedFiller.cxx

    Adding @goetz as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Jonathan Bossio resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :white_check_mark: CI Result SUCCESS (hash e7800cdc)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22508]

  • M
    Mike Hance @mhance
    Developer

    Changes look fine, tests pass, and all threads resolved. L1 approving.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit 898ec095

    mentioned in commit 898ec095

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply