Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 172
    • Merge requests 172
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !37603

Insert extra Filter nodes in DecisionSummaryMaker alg to resolve [ATR-21284]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Martin requested to merge tamartin/athena:createLinkingNodes into master Oct 26, 2020
  • Overview 11
  • Commits 3
  • Pipelines 2
  • Changes 10

Following on from ATR-21284, I discarded as un-workable the solutions to the following-unwanted-edged from HLTPassRaw problem which tried to resolve this via adding extra metadata.

The only remaining solutions it to add extra event data structure into the nav graph to prevent the following of unwanted-edges.

This MR adds extra Filter nodes into HLTNav_Summary which make sure that each exploration out from the HLTPassRaw node for a given chain only jumps into the graph at a node which definitely passed the event for that chain, not simply passed the hypo for that chain.

This is one half of the updates needed to do offline feature matching (cc @jburr)

In addition

  • Remove mentions of rerun from L1Decoder (cc @tbold)
  • Rework the manually created nav graph used to test feature retrieval. Update it to the new(ish) paradigm of ComboHypos and single InputMaker output collections. Include the new Filter objects added by this MR.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: createLinkingNodes