DerivationFramework: enable flake8

Enable the python checker (flake8) for all DerivationFramework packages and make the code compliant. The biggest change is to replace all import * with specific imports. Otherwise mostly trivial fixes including some mixed tabs/spaces. Non-trivial code that is broken was kept for documentation purposes and either commented or marked with noqa and a FIXME comment.

This merge request affects 61 files. Since this is a long list, I will not print it here.

Adding @nishu ,@dshope ,@spalazzo ,@borisov ,@guirriec ,@jmellent ,@tdado ,@oda ,@dguest ,@cvarni ,@bdong ,@lidiaz ,@zmarshal ,@rcreager ,@sanmay ,@jveatch ,@ispokhar ,@mhodgkin ,@nelsonc as watchers

added BTagging Derivation Egamma JetEtmiss Simulation Trigger master review-pending-level-1 labels

Due to the large amount of changes and since there are no unit or CI tests running this code, I would like a derivation expert to look at these changes and ideally run some tests on it (or advise what I should run). I hope one of the watchers can advise.

CI Result FAILURE (hash aa00e16c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22631]

added review-pending-expert label and removed review-pending-level-1 label

Tagging this for expert review. I'm not sure why the Overlay test failed here -- it doesn't seem connected to these changes. I'm guessing it will pass in future builds. -Mike (L1)

Jenkins please retry a build

This merge request affects 61 files. Since this is a long list, I will not print it here.

Adding @nishu ,@dshope ,@spalazzo ,@borisov ,@guirriec ,@jmellent ,@tdado ,@oda ,@dguest ,@cvarni ,@bdong ,@lidiaz ,@zmarshal ,@rcreager ,@sanmay ,@jveatch ,@ispokhar ,@mhodgkin ,@nelsonc as watchers

added review-pending-level-1 label and removed review-pending-expert label

CI Result SUCCESS (hash aa00e16c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22725]

added review-pending-expert label and removed review-pending-level-1 label

Tests are all passing now but adding back review-pending-expert until we get some feedback from the derivation experts - Tom (L1 shifter)

Hi @fwinkl ,

@egramsta has now stopped his role of derivations coordinator. To be honest I think I'm the only person who can be the "expert reviewer" here, as I wrote earlier.

Did you try to run the test job that I suggested above? Did it work with these changes in place?

James

P.S. It seems there is some feature of GitLab that I didn't see before. I replied to this a few days ago but it was somehow "pending" and needed a second click. No idea what that is for.

So please see my comment that I wrote 3 days ago but which wasn't posted...

resolved all threads

Just to remark to @tneep that we can go ahead and merge this.

James.

added review-pending-level-1 label and removed review-pending-expert label

resolved all threads

added review-approved label and removed review-pending-level-1 label

Thanks @jcatmore, I've marked as approved.