Skip to content
Snippets Groups Projects

Legacy jet monitoring tool default chain plotting changed for AthenaMT samples

Merged Jannik Geisen requested to merge jgeisen/athena:master into master
All threads resolved!

As discussed with @jbossios in this ticket: https://its.cern.ch/jira/browse/ATR-21819

I changed the legacy jet monitoring tool such that when running over AthenaMT input samples, the fillBasicHLTforChain function fills the default plots for "all jets" of the underlying jet container, while putting the "only jets that pass the chain criteria" into a subfolder chain_name+"/PassingJets"

Also tagging @khoo

Edited by Jannik Geisen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes mostly look fine, just added one comment above. Tests pass, so once the above thread is resolved we can approve this. -Mike (L1)

  • Jannik Geisen added 1 commit

    added 1 commit

    • 1309cb81 - removing commented out lines

    Compare with previous version

  • Jannik Geisen resolved all threads

    resolved all threads

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 128K in file Trigger/TrigMonitoring/TrigJetMonitoring/src/HLTJetMonTool.cxx

  • This merge request affects 2 files:

    • Trigger/TrigMonitoring/TrigJetMonitoring/src/HLTJetMonTool.cxx
    • Trigger/TrigMonitoring/TrigJetMonitoring/src/HLTJetMonTool.h
  • :white_check_mark: CI Result SUCCESS (hash 1309cb81)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22703]

  • merged

  • Edward Moyse mentioned in commit ab4e037c

    mentioned in commit ab4e037c

  • Please register or sign in to reply
    Loading