fix PixelGangedClusterAmbiguities "feature"

Some pixel clusters have the same identity PixelGangedClusterAmbiguities confuses them to be the same since it uses the identity to sort now use the width to sort when the identity is the same

added InnerDetector label

This merge request affects 2 files:

• InnerDetector/InDetRecEvent/InDetPrepRawData/InDetPrepRawData/PixelGangedClusterAmbiguities.h
• InnerDetector/InDetRecEvent/InDetPrepRawData/InDetPrepRawData/SiWidth.h

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

added master review-pending-level-1 labels

added urgent label

Thanks! Adding urgent label as this is required for the tracking CP feature freeze

added 1 commit

• 6d3a7b6a - avoid copy when not needed

Compare with previous version

This merge request affects 2 files:

• InnerDetector/InDetRecEvent/InDetPrepRawData/InDetPrepRawData/PixelGangedClusterAmbiguities.h
• InnerDetector/InDetRecEvent/InDetPrepRawData/InDetPrepRawData/SiWidth.h

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

CI Result SUCCESS (hash aa9b06da)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22707]

CI Result SUCCESS (hash 6d3a7b6a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22708]

added review-approved label

removed review-pending-level-1 label

Looks good, thanks

L2

mentioned in merge request !37704 (merged)

Should be merged Tuesday.

@goblirsc @vcairo is this okay to merge?

Hi @emoyse, ideally let's wait a little bit - we discussed this MR in ID Software yesterday and agreed on a few quick extra checks which are being tracked at https://its.cern.ch/jira/browse/ATLIDTRKCP-302. We will need to merge this one before merging !37772 (merged) (since the "feature" here can lead to rare segfaults when interacting with the new network implementation), but since that one is due Thursday, we can maybe take one day to finalise this one, and consider !37704 (merged) for today? @gfacini / @sroe / @vcairo, please feel free to comment if you disagree!

I'll go ahead with !37704 (merged) soon if there are no objections.

I want to dig deeper here, but I think this MR should go in in the mean time.

Okay. Merging.

merged