Skip to content
Snippets Groups Projects

Flow Element validation plots

Hi

This merge request is for histogram booking of Flow Elements and Particle Flow Objects (PFOs). The implementation I made basically uses the same classdefs & fill functions to book histograms for FlowElements as PFOs without duplicate classes. I've added the routine to run it in PhysValMonitoring/share/PhysValPFlow_FlowElements.py which can now be called from eflowRec using the doFlowElementValidation eflowRecflag.

Concerning the large number of files configured here: all of them are related to the headers+ sources of the respective classes used for histogram booking (which is kind of a tree like structure of tools). Also needed to update the PhysValPFO class to use the modified classes or updating the cmake inclusions.

Thanks

Matt

Edited by Matthew Thomas Anthony

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Hodgkinson
  • added 1 commit

    Compare with previous version

  • This merge request affects 26 files. Since this is a long list, I will not print it here.

    Adding @goetz ,@mhodgkin as watchers

  • :white_check_mark: CI Result SUCCESS (hash 6fcbab6f)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23235]

  • There is still one unresolved thread, changing label to review-user-action-required. Please change the label back once it is resolved. Thanks, Pienpen(L1)

  • added 1 commit

    • ecb14bb8 - add Validation plots to eflowRec routine

    Compare with previous version

  • Matthew Thomas Anthony marked as a Work In Progress

    marked as a Work In Progress

  • Jenkins please retry a build

  • Matthew Thomas Anthony resolved all threads

    resolved all threads

    • Resolved by Matthew Thomas Anthony

      having also checked the make log, it is a -wunused parameter warning in an default function . Basically, this section is a prototype that will be filled in a later merge request.

      If this warning needs to be removed I will put in a temporary statement in the function (say read off pT of the object) that will "use" the parameter.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading