Flow Element validation plots
Hi
This merge request is for histogram booking of Flow Elements and Particle Flow Objects (PFOs).
The implementation I made basically uses the same classdefs & fill functions to book histograms for FlowElements as PFOs without duplicate classes. I've added the routine to run it in PhysValMonitoring/share/PhysValPFlow_FlowElements.py
which can now be called from eflowRec using the doFlowElementValidation
eflowRecflag.
Concerning the large number of files configured here: all of them are related to the headers+ sources of the respective classes used for histogram booking (which is kind of a tree like structure of tools). Also needed to update the PhysValPFO class to use the modified classes or updating the cmake inclusions.
Thanks
Matt
Merge request reports
Activity
Hi @mhodgkin
The algorithm(s) for the FlowElement validation are now ready for review.
In essence, I've overloaded some of the PFO_BLAHHPlots' fill functions to plot FE instead of PFO.
We now have separate TH1s booked for PFO and FE to avoid confusion.
A few switches now exist (based on whether you want to use PFO or FlowElements), but default PFO validation routine and FE validation routines have been set appropriately. I've checked both run as expected and see no unusual behaviour.
Validation algorithm for Flow Elements is called using validation flag
doPFlow_FlowElements
.Validation algorithm now produces identical sets of plots for FE as for PFO (except where auxvars were known to be missing, as we've discussed before).
Added the plots based on FlowElement Links to leptons/photons (i.e FE -> lepton).
Will remove WIP status when you're finished with the review.
Thanks
Matt
Edited by Matthew Thomas Anthonyadded Analysis JetEtmiss Reconstruction master review-pending-level-1 labels
CI Result SUCCESS (hash e65c6e2b)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23191]- Resolved by Matthew Thomas Anthony
- Resolved by Matthew Thomas Anthony
CI Result SUCCESS (hash 6fcbab6f)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23235]added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Matthew Thomas Anthony
having also checked the make log, it is a
-wunused parameter
warning in an default function . Basically, this section is a prototype that will be filled in a later merge request.If this warning needs to be removed I will put in a temporary statement in the function (say read off pT of the object) that will "use" the parameter.