Correct allowed bTag WPs, update references related with b-jet chains and add...

Correcting allowed bTag WPs, updating references related with b-jet chains and adding ERROR exit of the code when no proper chain bit is found. This MR is to cure the issues risen in JIRAs: ATR-22165, ATR-22183 and ATR-22180.

added Trigger TriggerMenu master labels

WARNING: big files (>100K) are found in the changeset

232K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

240K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 4 files:

• Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref
• Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref
• Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/GenerateMenuMT.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/SignatureDicts.py

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@bernius ,@hrussell ,@ckaldero ,@malconad ,@jpanduro as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 3e4bb6fd)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23052]

added review-user-action-required label

removed review-pending-level-1 label

Hi @tneep, this is a temporary long waited fix agreed with experts, pls approve it. thanks

I don't think it is a completely unreasonable request, there are two other places in this file where exceptions are raised and no other places where sys.exit is called, so it would be nice to be consistent. I don't want to hold you up so I'll send to L2 to decide.

added review-pending-level-2 label and removed review-user-action-required label

@maliev seeing as this is the second time its come up could you just change the lines

import sys
sys.exit(msg)

to

raise Exception(msg)

there's no need to rerun the references or anything from this change, it should be pretty simple.

added 1 commit

• d3cdc97d - change sys.exit(} to raise Exception()

Compare with previous version

WARNING: big files (>100K) are found in the changeset

232K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

240K in file Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref

This merge request affects 4 files:

• Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref
• Trigger/TrigValidation/TriggerTest/share/ref_data_v1Dev_build.ref
• Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/GenerateMenuMT.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/SignatureDicts.py

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@bernius ,@hrussell ,@ckaldero ,@malconad ,@jpanduro as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

CI Result SUCCESS (hash d3cdc97d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23103]

resolved all threads

added review-approved label

removed review-pending-level-1 label