Skip to content
Snippets Groups Projects

Common ReadoutGeometry Base Class for InDet and HGTD (SolidStateReadoutGeometry)

Merged Nicholas Styles requested to merge nstyles/athena:master-ReadoutGeometryBase into master

Initial implementation of common ReadoutGeometry base for use by InnerDetector and HGTD derived classes. Porting of work done in 21.9 (including ITk and HGTD specific updates) with AthenaMT changes in master.

Removed some methods from DetectorElementBase which (probably) do not belong in Base class, but rather in derived classes. Otherwise, method interfaces should remain as in master with some internal implementation updates. Some additions to the Design class to allow specializations based on the design.

For shifter info:

  • The substantive changes are limited to InDetReadoutGeometry and the new ReadoutGeometryBase class
  • ReadoutGeometryBase becomes the base class for InDetReadoutGeometry, and so a number of functions move into the base class. Their implementation should be functionally equivalent, but may not be 100% identical due to a) trying to reduce the remaining use of intermediate CLHEP matrices/vectors/transforms in favour of going straight to Eigen, and b) introducing features needed for ITk/HGTD
  • The changes outside InDetReadoutGeometry and ReadoutGeometryBase are simply to update the package location from which headers are taken
Edited by Nicholas Styles

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 25e40965 - start updating derived classes

    Compare with previous version

  • Nicholas Styles
  • added 1 commit

    • c062491a - start updating derived classes

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 19131b89 - compiling version of intial intgration of base class into (newly) derived classes

    Compare with previous version

  • added 1 commit

    • 6cb91bd4 - propagate ReadoutGeometry restructuring to StripGeoModelXml

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c347c7ba - compiling version after duplicate removal

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Nicholas Styles changed the description

    changed the description

  • Nicholas Styles unmarked as a Work In Progress

    unmarked as a Work In Progress

  • This merge request affects 69 files. Since this is a long list, I will not print it here.

    Adding @goetz ,@stsuno ,@oda ,@lshan ,@battagl ,@sroe ,@nkoehler ,@rbianchi as watchers

  • Nicholas Styles marked as a Work In Progress

    marked as a Work In Progress

  • :negative_squared_cross_mark: CI Result FAILURE (hash 13c339d9)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 7, warnings 12
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23580]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading