Common ReadoutGeometry Base Class for InDet and HGTD (SolidStateReadoutGeometry)
Initial implementation of common ReadoutGeometry base for use by InnerDetector and HGTD derived classes. Porting of work done in 21.9 (including ITk and HGTD specific updates) with AthenaMT changes in master.
Removed some methods from DetectorElementBase which (probably) do not belong in Base class, but rather in derived classes. Otherwise, method interfaces should remain as in master with some internal implementation updates. Some additions to the Design class to allow specializations based on the design.
For shifter info:
- The substantive changes are limited to
InDetReadoutGeometry
and the newReadoutGeometryBase
class -
ReadoutGeometryBase
becomes the base class forInDetReadoutGeometry
, and so a number of functions move into the base class. Their implementation should be functionally equivalent, but may not be 100% identical due to a) trying to reduce the remaining use of intermediate CLHEP matrices/vectors/transforms in favour of going straight to Eigen, and b) introducing features needed for ITk/HGTD - The changes outside
InDetReadoutGeometry
andReadoutGeometryBase
are simply to update the package location from which headers are taken
Merge request reports
Activity
added 1 commit
- c02bdaf9 - removed methods that don't seem needed in base class
added 1 commit
- 45b1406b - remove some more methods, make others virtual
- Resolved by Nicholas Styles
- Resolved by Nicholas Styles
added 1 commit
- 19131b89 - compiling version of intial intgration of base class into (newly) derived classes
added 1 commit
- 6cb91bd4 - propagate ReadoutGeometry restructuring to StripGeoModelXml
added Geometry InnerDetector JetEtmiss master review-pending-level-1 labels
removed review-pending-level-1 label
CI Result FAILURE (hash 13c339d9)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 7, warnings 12
AthSimulation: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23580]