IOVSvc: Remove locking from CondSvc::isValidID.

The locking within CondSvc::isValidID is heavily contended in jobs with many threads (32-64). Rework so that we don't need to use locking.

Rather than doing a SG lookup each time isValidID is called, we instead build a map from SG key to CondCont instances at the end of initialization. (This is called from CondInputLoader::start). We can then look up the key directly in this map rather then querying SG. Since this map is modified only during START, we don't need any locking.

This merge request affects 4 files:

• Control/IOVSvc/src/CondInputLoader.cxx
• Control/IOVSvc/src/CondSvc.cxx
• Control/IOVSvc/src/CondSvc.h
• Control/IOVSvc/src/ICondSvcSetupDone.h

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

CI Result SUCCESS (hash b1af5f8b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23274]

resolved all threads

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3ce02e05

added sweep:ignore label