LArG4Barrel: Fix cppcheck warnings.

• Prefer using an initialization list to initializing members in a ctor body.
• Pass class instances by const reference, not by value.

This merge request affects 16 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/AccMap.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/AccMap.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArCoudeAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArCoudeAbsorbers.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArCoudeElectrodes.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArCoudeElectrodes.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.h
• LArCalorimeter/LArG4/LArG4Barrel/src/MapEta.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/MapEta.h
• LArCalorimeter/LArG4/LArG4Barrel/src/PhysicalVolumeAccessor.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/PhysicalVolumeAccessor.h
• LArCalorimeter/LArG4/LArG4Barrel/src/PsMap.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/PsMap.h

Adding @pavol as watcher

added JetEtmiss LAr Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash 2696c7cf)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23374]

• ctors used the way they should be
• pass by ref for objects
• technical debt: paid

L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 69b14cdf

added sweep:ignore label