22.0-cleanup2-SiClusterizationTool

This follows from !37993 (closed) which I closed as it picked up a lot of conflicts after urgent bug fixing. Primarily improve error reporting so use of at() with an index out of range is trapped and reports a meaningful ATH_MSG_FATAL message instead of creating an exception (in context of ATLIDTRKCP-302). Other cleanups done: use of cmath constants instead of TMath, tidy up includes, use of std::array instead of a c style array, clarification of the declaration and usage of a pointer-to-member-function variable.

This merge request affects 2 files:

• InnerDetector/InDetRecTools/SiClusterizationTool/SiClusterizationTool/NnClusterizationFactory.h
• InnerDetector/InDetRecTools/SiClusterizationTool/src/NnClusterizationFactory.cxx

Adding @goetz ,@amorley ,@oda ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result SUCCESS (hash edc56ab7)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23436]

added review-approved label and removed review-pending-level-1 label

mentioned in merge request !38073 (merged)

merged

mentioned in commit 49239451

added sweep:ignore label