Try setting the maximum number of tubes to 120 when building MDT GeoSerialIdentifiers

Hi,

as the name suggests, this MR is to find potential issues in the incremental build when setting the maximum number of tubes to 120 when building MDT GeoSerialIdentifiers.

Best, Nico

added full-build label

added full-unit-tests label

marked as a Work In Progress

WARNING: big files (>100K) are found in the changeset

140K in file MuonSpectrometer/MuonDigitization/RPC_Digitization/src/RpcDigitizationTool.cxx

104K in file MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring/src/MdtRawDataValAlg.cxx

build area is cleaned as MR is labeled as full-build

This merge request affects 10 packages:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDigitization/RPC_Digitization
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModel
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• Tracking/TrkUtilityPackages/TrkDriftCircleMath
• Trigger/TrigAlgorithms/TrigL2MuonSA

Affected files list will not be printed in this case

Adding @jchapman ,@goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

added DQ Digitization MuonSpectrometer Simulation Tracking Trigger master review-pending-level-1 labels

CI Result FAILURE (hash a7bda1ea)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23778]

added 94 commits

• a7bda1ea...ee451962 - 90 commits from branch atlas:master
• 6de4c4bf - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into tryTube
• 8c66ec68 - Merge branch 'tryTube' of ssh://gitlab.cern.ch:7999/nkoehler/athena into tryTube
• 6b6b1873 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into tryTube
• 2982657c - use constexpr

Compare with previous version

added 1 commit

• 53677943 - fix compilation

Compare with previous version

unmarked as a Work In Progress

WARNING: big files (>100K) are found in the changeset

104K in file MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring/src/MdtRawDataValAlg.cxx

build area is cleaned as MR is labeled as full-build

This merge request affects 8 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModel
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• Tracking/TrkUtilityPackages/TrkDriftCircleMath
• Trigger/TrigAlgorithms/TrigL2MuonSA

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

CI Result FAILURE (hash 53677943)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23826]

added 1 commit

• 0847fbac - remove double definition

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring/src/MdtRawDataValAlg.cxx

build area is cleaned as MR is labeled as full-build

This merge request affects 8 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModel
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• Tracking/TrkUtilityPackages/TrkDriftCircleMath
• Trigger/TrigAlgorithms/TrigL2MuonSA

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

CI Result FAILURE (hash 0847fbac)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23850]

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

104K in file MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring/src/MdtRawDataValAlg.cxx

build area is cleaned as MR is labeled as full-build

This merge request affects 8 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModel
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• Tracking/TrkUtilityPackages/TrkDriftCircleMath
• Trigger/TrigAlgorithms/TrigL2MuonSA

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

CI Result FAILURE (hash 0847fbac)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23857]

Hello, there are 2 failures in unit-tests: PhotonVertexSelection_PhotonVertexSelection_test_ctest and PyJobTransforms_trfReportsSignaledExit_ctest. The first one is also failing in the nightly but the second one does not seem to be the case. Could you please have a look into it? Thanks, Pienpen (L1)

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

104K in file MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring/src/MdtRawDataValAlg.cxx

build area is cleaned as MR is labeled as full-build

This merge request affects 8 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModel
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• Tracking/TrkUtilityPackages/TrkDriftCircleMath
• Trigger/TrigAlgorithms/TrigL2MuonSA

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

added review-pending-level-1 label and removed review-user-action-required label

Out of curiosity, why do you use full-build for this MR? I don't see any changes that would require that.

CI Result SUCCESS (hash 0847fbac)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23882]

resolved all threads

Hi Nico, just to clarify the wording. By overlay, do you mean MC+MC overlay, or standard pile-up digitisation?

I'm currently preparing some ART tests based on the HITS @alaurier pointed me to, but I'm happy to update to new ones when available.

added review-approved label and removed review-pending-level-1 label

resolved all threads

merged

mentioned in commit 20d0c46b

added sweep:ignore label

mentioned in merge request !38840 (merged)