Replace TriggerFlags.EDMDecodingVersion with ConfigFlags.Trigger.EDMVersion and remove TriggerFlags.doMT
After !38381 (merged) we can now rely fully on the auto-configuration of EDMDecodingVersion
from ConfigFlags.Trigger
. Clean up the now-redundant old code. In addition, clean up all use-cases (some incorrect) of TriggerFlags.doMT
and use other flags in its place.
Detailed changes:
- Replace
TriggerFlags.EDMDecodingVersion
withConfigFlags.Trigger.EDMDecodingVersion
- Deprecate but keep
TriggerFlags.EDMDecodingVersion
and auto-configure it to the value ofConfigFlags.Trigger.EDMDecodingVersion
- Replace all use cases of the old flag with the new one
- Remove the old "auto" configuration function, which wasn't "auto" (it had to be called separately from the flag)
- Deprecate but keep
- Rename
EDMDecodingVersion
toEDMVersion
because it doesn't steer just decoding, but also encoding (i.e. defines what is added to the trigger output). - Remove
TriggerFlags.doMT
- Use
ConfigFlags.Trigger.EDMVersion
where the intention was to check for Trigger EDM version - Use
ConfigFlags.Concurrency.NumThreads
where the intention was to check for running AthenaMT vs serial athena
- Use
This touches many domains, so adding full-unit-tests
Closes ATR-22360
Edited by Rafal Bielski