xAODRootAccess: Don't crash opening a schema-evolved file.
Don't crash opening a file that uses some kinds of automatic schema evolution. If the type of a member changes from one class to another (for example, from std::vector to std::vector), then GetExpectedType will give us the on-disk class. To get the class we use in memory, we need to use GetCurrentClass.
Merge request reports
Activity
added Core Tau master review-pending-level-1 labels
CI Result SUCCESS (hash 2156115d)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23790]- Resolved by Attila Krasznahorkay
hi -
After the previous discussions, i thought i'd add a test of automatic double->float evolution to DataModelTests. (Part of it was that i wasn't completely sure that it worked for nested vectors.)
Everything worked except for the test where i try to read a file using TEvent instead of AthenaPOOL, which crashed. I needed the change here to fix the crash. (In the TEvent test, i don't actually try to read the object that used schema evolution, since there are other changes there that TEvent won't handle. I do, however, try to read other objects from the same file, and TEvent was crashing just opening the file.)
added review-user-action-required label and removed review-pending-level-1 label
added review-approved label and removed review-user-action-required label
mentioned in commit aa2aec5c
added sweep:ignore label
mentioned in merge request !38577 (merged)