Removed callback registration from AmdcsimrecAthenaSvc

Given Muon alignment handling has been transitioned to condition algorithms, the callback registration for fetching Muon alignments became redundant. With this change AmdcsimrecAthenaSvc gets all required information from the MuonDetectorManager at initialization.

If in the future somebody desires to make AmdcsimrecAthenaSvc sensitive to Muon alignment values, then a substantial redesign of this service, and other services that depend on it, will be required.

As a bonus, with this change we drop the last remaining client of the IGeoModelSvc::align() function, such that the latter can now be removed.

CC @nkoehler and @mnowak

changed the description

This merge request affects 1 package:

• MuonSpectrometer/Amdcsimrec/AmdcAth

This merge request affects 2 files:

• MuonSpectrometer/Amdcsimrec/AmdcAth/AmdcAth/AmdcsimrecAthenaSvc.h
• MuonSpectrometer/Amdcsimrec/AmdcAth/src/AmdcsimrecAthenaSvc.cxx

Adding @rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS (hash 01c5fd8b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23848]

code seems o.k., CI passed, approving.

Roman(L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 22f95185

merged

added sweep:ignore label

mentioned in merge request !38096 (merged)