Skip to content

Gaudi Fixes, master branch (2020.11.22.)

Attila Krasznahorkay requested to merge akraszna/athena:GaudiFixes-master-20201122 into master

This MR is meant to fix the issues introduced by !38429 (merged).

The more serious one is that with the latest Athena,master,x86_64-centos7-gcc8-opt nightly one runs into the following kinds of errors while trying to build some packages against the nightly:

...
-- Found CppUnit: /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_2/CppUnit/1.14.0/x86_64-centos7-gcc8-opt/include  
-- Found libunwind: /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_2/libunwind/1.3.1/x86_64-centos7-gcc8-opt/include  
CMake Warning at /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_2/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/cmake/Boost-1.73.0/BoostConfig.cmake:141 (find_package):
  Found package configuration file:

    /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_2/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/cmake/boost_system-1.73.0/boost_system-config.cmake

  but it set boost_system_FOUND to FALSE so package "boost_system" is
  considered to be NOT FOUND.  Reason given by package:

  No suitable build variant has been found.

  The following variants have been tried and rejected:

  * libboost_system.so.1.73.0 (release runtime, Boost_USE_DEBUG_RUNTIME=TRUE)

  * libboost_system.a (static, Boost_USE_STATIC_LIBS=OFF)

Call Stack (most recent call first):
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3_ATLAS_2/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/cmake/Boost-1.73.0/BoostConfig.cmake:258 (boost_find_component)
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-11-21T2101/AthenaExternals/22.0.21/InstallArea/x86_64-centos7-gcc8-opt/lib/cmake/Gaudi/GaudiDependencies.cmake:98 (find_package)
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-11-21T2101/AthenaExternals/22.0.21/InstallArea/x86_64-centos7-gcc8-opt/lib/cmake/Gaudi/GaudiConfig.cmake:130 (include)
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-11-21T2101/Athena/22.0.21/InstallArea/x86_64-centos7-gcc8-opt/cmake/modules/FindGaudi.cmake:43 (find_package)
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-11-21T2101/Athena/22.0.21/InstallArea/x86_64-centos7-gcc8-opt/cmake/PostConfig.cmake:24 (find_package)
  /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-11-21T2101/Athena/22.0.21/InstallArea/x86_64-centos7-gcc8-opt/cmake/AthenaConfig.cmake:369 (include)
  CMakeLists.txt:40 (find_package)
...

I have to admit, I still don't fully understand why this issue only shows up when using Projects/WorkDir, and didn't show up when building Athena itself... 😕 But after some trial-and-error I decided to fix it with: atlasexternals!774 (d5387452)

This means that this MR updates all projects to atlasexternals-2.0.87, which adds this one change on top of atlasexternals-2.0.86. (atlasexternals@2.0.86...2.0.87) I was pondering for a moment about possibly updating the default Gaudi version built by the new tag, but in the end decided against doing more changes than absolutely necessary.

The other fix of the MR is for one failure that we already noticed in !38429 (merged). The unit test in PhotonVertexSelection was making use of an algorithm that's built as part of GaudiExamples. But with the new CMake configuration we are not building GaudiExamples anymore...

Since luckily we already had an equivalent algorithm built as part of our own repository that I could swap in, I just did that. 😉

Note that the change in the externals is small enough that this does not need full-build.

Merge request reports