Skip to content
Snippets Groups Projects

Small-R truth jets in DAOD_PHYS

Merged Chris Malena Delitzsch requested to merge cdelitzs/athena:master-truth-jets into master
All threads resolved!

This MR implements the following

(1) Changes in MCTruthCommon allow to add small-R jets in DAOD_PHYS. This was implemented by switching back to the old way of setting up things. The current implementation causes problems when scheduling jet reconstruction in different places. In the future we will switch to the new configuration hopefully everywhere

(2) Fix the MET_track container name in fJVT calculation

(3) Add calculation of event level cleaning variables

Item (1) makes @zmarshal happy hopefully :) Item (2) and (3) were reported in ATLPHYSVAL-671

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @cdelitzs , this is great!

    Just to check, does this also restore the flavor tagging variables?

  • added 1 commit

    Compare with previous version

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
    • Reconstruction/Jet/JetMomentTools

    Affected files list will not be printed in this case

    Adding @zmarshal ,@goetz ,@jmellent ,@jveatch ,@nelsonc ,@dshope ,@ispokhar as watchers

  • Hi @zmarshal,

    yes, this should include also variables like GhostBHadrons, PartonTruthLabelID.

    Cheers, Chris

  • Zach Marshall resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash a849104f)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23887]

  • Chris Malena Delitzsch resolved all threads

    resolved all threads

  • No outstanding issue to L1, escalating to L2 for another look into MCTruthCommon.py. Thanks, Pienpen (L1)

  • Looks good to me. Karolos (L2)

  • mentioned in commit 43120263

  • Please register or sign in to reply
    Loading