Skip to content
Snippets Groups Projects

Fix memory leaks in jet reconstruction

Merged Fix memory leaks in jet reconstruction
wbalunas/athena:jvtLeak-201124 into master
Merged William Keaton Balunas requested to merge wbalunas/athena:jvtLeak-201124 into master

This fixes a few memory leaks in jet reconstruction:

  • ATLASRECTS-5790: A histogram in the JVT tool which is allocated by a call to TDirectoryFile::Get(...) but never deleted
  • ATLASRECTS-5681: A subtle double-copy of an IConstituentExtractor in ExtractorRange::bump(...) where clone() was being called once in the function and again in the implicit copy-constructor used in the return statement.
  • Some histograms being grabbed from ROOT files and not deleted in jet calibration tools.

I've also cleaned up the destructor for JMSCorrection for simplicity while I was checking these.

Edited by William Keaton Balunas

Merge request reports

Pipeline #2121680 passed

Stage: external

    Pipeline passed for 1bcadc57 on wbalunas:jvtLeak-201124

    Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Nov 25, 2020 3:02pm UTC)

    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply