Skip to content

HltEventLoopMgr: modernise and fix some clang-tidy warnings

Rafal Bielski requested to merge rbielski/athena:hltelm-clang-tidy into master

Apply the following changes to HltEventLoopMgr.cxx/.h:

  • Use default destructor and default-initialise members in the header
  • Do not assign the return value of Monitored::Group to a named variable
  • Fix multiple clang-tidy warnings, including some instances of:
    • Method called on moved-from object [clang-analyzer-cplusplus.Move]
    • Macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
    • 1000000000 is a magic number [cppcoreguidelines-avoid-magic-numbers]
    • slicing object from type EventID to EventIDBase [cppcoreguidelines-slicing]
    • some warnings regarding the use of new [cppcoreguidelines-owning-memory]
    • implicit conversion to bool (mostly from pointers) [readability-implicit-bool-conversion]
    • do not use 'else' after 'return' / 'continue' [readability-else-after-return]
    • one case of unnecessary copy [performance-unnecessary-value-param]

For RC: Please do squash the commits (I checked the box)

Merge request reports