Handle combined chains in summary making ATR-22304

With this we should have proper navigation information for multileg chains (combined chains). However, while testing I could not spot any such chains in LS2_v1 ... Tagging @tamartin @fpastore

I see that my editor cleaned trailing spaces. Sorry about that. Pleas review ignoring whitespace.

This merge request affects 2 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @tamartin ,@rbielski as watchers

added Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 06d7d7c0)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24248]

added 1 commit

• 9865cc52 - Remove unnecessary import

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @tamartin ,@rbielski as watchers

CI Result SUCCESS (hash 9865cc52)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24264]

Thanks @tbold !

We can test with HLT_e17_lhloose_mu14_L1EM15VH_MU10, if we request auto fs = m_tdt->features<xAOD::IParticleContainer>("HLT_e17_lhloose_mu14_L1EM15VH_MU10"); then we should get back final electrons and muons.

Changes looks fine from MR shifter point ov view, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

marked as a Work In Progress

No, please do not merge it yet. @tamartin comment pointed to a bug that resided there for long.

removed review-approved label

added 1 commit

• 3efa520b - Fixed fetching containers from ComboHypos

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @tamartin ,@rbielski as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 3efa520b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24370]

Now the changes on the python made some difference (we used to only look only one (1st) collection output by Combo). When we look at all of them the counts of objects increased as expected:

chainComp INFO       HLT_mu24_mu10noL1_L1MU20:
chainComp INFO         stepFeatures:
chainComp INFO           0: 1 -> 2
chainComp INFO           1: 1 -> 2

However, there are come chains that follow slightly different patterns. This one is understandable because the second collection that is considered now is for photons and in inclusive chain we havs many features.

chainComp INFO       HLT_e3_etcut1step_g5_etcut_L12EM3:
chainComp INFO         stepFeatures:
chainComp INFO           0: 23 -> 57
chainComp INFO           1: 23 -> 57
chainComp INFO           2: 23 -> 66

But the change in these chains makes no sense to me. Especially because they are not combos and their result is read from the same output collection.

chainComp INFO       HLT_xe30_mhtpufit_em_subjesgscIS_L1XE10:
chainComp INFO         eventCount: 4 -> 2
chainComp INFO         stepCounts:
chainComp INFO           1: 4 -> 2
chainComp INFO         stepFeatures:
chainComp INFO           1: 4 -> 2
chainComp INFO       HLT_xe30_trkmht_L1XE10:
chainComp INFO         eventCount: 7 -> 6
chainComp INFO         stepCounts:
chainComp INFO           1: 7 -> 6
chainComp INFO         stepFeatures:
chainComp INFO           1: 7 -> 6

Looks like there are still conversations to resolve. Sending back to developer.

added review-user-action-required label and removed review-pending-level-1 label