Import ElectronPhotonFourMomentumCorrection r21.2->r22
Importing ElectronPhotonFourMomentumCorrection from r21.2 -> r22
- Minimal
CMakeLists.txtcleanup - Whitespace fixes & removing editor specific characters
- Copyright -> 2020 increase
Compilation appears fine, but package not thoroughly tested yet. (tested with AB,r29 given today's nightly issues)
Merge request reports
Activity
@christos, this is a blind import from 21.2, and it's still WIP, please review essential issues first/only.
I agree with @salderwe. This MR is part of an urgent (marking it as such) effort in the analysis software area and a sweep from 21.2. This was work done by @salderwe who is not necessarily responsible for the code. It'd be great if cleanup requests could be done by the Egamma group after the sweep is one.
added urgent label
-
@lheinric I understand you point. But also reverting work of people done in the context of MT is actually not what I would describe as the "nicest thing to do".
So I am fine but please point exactly with what you agree to be clear? And what is "essential" in this context. You are bringing in changes @gunal and I did in 21.2 , but also reverting changes done in the athena MT context, and at the time both I and @gunal did them in the context of Egamma group. So is a bit self-defeating to do it like this.
So I understand your point but I think also what I try to say is also kind of clear. Why we have reached a stage where things become urgent in > 1 fronts with less CP manpower in specific items I guess is a discussion for the post-mortem in 6 months ...
Edited by Christos Anastopoulos added 2 commits
-
@christos , I tried to fix the places where r22 efforts were undone. We'd like this merged soon, but indeed undoing work is silly. If you spot any more please let us know.