Skip to content
Snippets Groups Projects

21.9: Removing if statements to re-update support's radii based on the dimension of ring's logical volume

Merged Noemi Calace requested to merge ncalace/athena:21.9-overlaps into 21.9
All threads resolved!

Self-explanatory title. I have used the check on the xml version to assure backward compatibility and tested it with RunUpgradeTests.py -s.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • code changed look fine, except for one issue above, CI passed. Once the above issue is resolved, it should be good to go.

    Roman(L1)

  • Noemi Calace added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • InnerDetector/InDetDetDescr/PixelLayouts/EndcapRingRef

    This merge request affects 1 file:

    • InnerDetector/InDetDetDescr/PixelLayouts/EndcapRingRef/src/GeoPixelLayerECRingRefTool.cxx

    Adding @goetz ,@lshan ,@battagl ,@sroe ,@stsuno as watchers

  • Roman Lysak resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 907a9926)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45320]

  • Tadej Novak mentioned in commit 4212c0c9

    mentioned in commit 4212c0c9

  • merged

  • added review-approved label and removed review-pending-level-1 label

  • Please register or sign in to reply
    Loading