EventSplit test streams write to seperate files Fixes ATEAM-682
This is a follow up to !38671 (closed) and !38655 (merged)
Correct the AthenaPoolMultiTest_AthenaPoolMultiTestEventSplit_ctest
to have each of the split streams write to a separate file. The "Bad" stream was sharing an output file with the "Others" stream, probably by accident.
Rationale: setting multiple streams to write to the same file causes problems. Should the streams' metadata item lists overlap the shared items will add more entries to the metadata tree than the others causing a failure when attempting to close the file after writing. If the two lists are the same the resulting metadata tree has multiple entries, which may lead to undefined behavior.
There is no reason to expect multiple output streams to need to write to the same file. We do not support that configuration, and should not test for it.
Bonus (?): adds some lines that seem to have appeared from a change to the TrkTrackSummaryUpdater
Merge request reports
Activity
This merge request affects 1 package:
- AtlasTest/DatabaseTest/AthenaPoolMultiTest
This merge request affects 5 files:
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/AthenaPoolMultiTestEventNoSplit.ref
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/AthenaPoolMultiTestEventSplit.ref
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/AthenaPoolMultiTestEventSplitDecision.ref
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/AthenaPoolMultiTestPropagate.ref
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/EventSplit_jo.py
added Test master review-pending-level-1 labels
CI Result FAILURE (hash a7d2ccef)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24456]Please address the unit test fails: The following tests FAILED: 20 - AthenaPoolMultiTest_AthenaPoolMultiTestEventSplit_ctest (Failed) 21 - AthenaPoolMultiTest_AthenaPoolMultiTestEventSplitDecision_ctest (Failed) 22 - AthenaPoolMultiTest_AthenaPoolMultiTestEventNoSplit_ctest (Failed) 23 - AthenaPoolMultiTest_AthenaPoolMultiTestPropagate_ctest (Failed) (L1)
added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- 3f7cdb30 - Ignore ConfigurableDb warnings in stream test
This merge request affects 1 package:
- AtlasTest/DatabaseTest/AthenaPoolMultiTest
This merge request affects 4 files:
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/AthenaPoolMultiTestEventSplit.ref
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/share/EventSplit_jo.py
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/test/post_check_es.sh
- AtlasTest/DatabaseTest/AthenaPoolMultiTest/test/post_check_p.sh
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 3f7cdb30)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24508]added review-approved label and removed review-pending-level-1 label
mentioned in commit bbc200aa
added sweep:ignore label