Hepmc3 nightly fixes 03122020 part 1

In this MR:

• Use auto to match GenParticlePtr/GenParticle*
• Use C++11 loops for HEpMC3 compatibility
• use ifdef to deal with sysntax update for particles_size() vs particles().size()
• use free function barcode for HepMC3 compatibility

changed title from Hepmc3 nightly fixes 03122020 part 1 to WIP Hepmc3 nightly fixes 03122020 part 1

This merge request affects 3 packages:

• Calorimeter/CaloLocalHadCalib
• MuonSpectrometer/MuonValidation/MuonPRDTest
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker

Affected files list will not be printed in this case

Adding @pavol ,@rosati ,@nkoehler ,@wleight as watchers

added Analysis Calorimeter JetEtmiss MuonSpectrometer master review-pending-level-1 labels

Jenkins please try a rebuild

looks like, it's not ready for review, changing labels. Please update the description. Also, if you want rebuild, the comment should be different, see: https://atlassoftwaredocs.web.cern.ch/guides/MR_reviewers/#faq5 Moreover, I'm not sure 'WIP' is enough in title, maybe 'WIP:' is needed to mark it as work in progress? (since there should be a comment about this from ATLAS Robot and it's not there)

Roman(L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @rlysak ,

the MRs with WIP in the title should not be reviewed.

Best regards,

Andrii

CI Result SUCCESS (hash ef86ce63)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24561]

changed title from WIP Hepmc3 nightly fixes 03122020 part 1 to Hepmc3 nightly fixes 03122020 part 1

changed the description

added review-pending-level-1 label and removed review-user-action-required label

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 79f32575

added sweep:ignore label