Start a bit of cleanup on I(Extended)TrackSummaryTool
requested to merge ATLAS-EGamma/athena:InDetTrackSummaryHelperTool_addDetailedTrackSummary_ctx_aware into master
This started as an effort to remove
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Woverloaded-virtual"
and to pass the EventContext
in a couple of methods.
These interfaces are a bit confusing and tried to make it a bit less so.
We had/have 2 :
- ITrackSummaryHelperTool which is kind of the pre-MT one , or when there are not MT issues
- IExtendedTrackSummaryHelperTool . The later has additional methods and we can pass around a
PRDtoTrackMap
andEventContext
We have 3 implementations InDet
, Muon
, ISF
but not all have to implement all the methods
Also, for compatibility reason the IExtendedInterface needs to implement some of the older std methods in terms of the new ones.
Anyhow, at least I managed to remove the "-Woverloaded-virtual" , pass a bit more the eventContext around, and hopefully make what implements what a bit cleaner.
Mentioning @sroe
Edited by Christos Anastopoulos