Skip to content
Snippets Groups Projects

PerformanceMonitoring: First batch of cmake, flake8, clean-up updates

Merged Alaettin Serhan Mete requested to merge amete/athena:master-perfmon-flake8-batch1 into master

This relates to ATEAM-678. The original goal was to enable flake8 for the packages under Control/PerformanceMonitoring. While doing so, I tried to clean things up that I'm fairly certain not used and/or needed anymore, although I played it safe. I also went through the cmake configurations, fixed a number of py3 problems in some scripts that are not used very frequently etc. It turned out to be a bit more massive MR than I was intending but pretty much all changes are either stylistic and/or uncontroversial. There is essentially no new functionality.

BTW, there are a few commits but it would be nice if we don't squash them just in case.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS (hash cde11f98)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 24612]

  • Abhishek Nag
  • Liza Mijovic resolved all threads

    resolved all threads

  • Liza Mijovic resolved all threads

    resolved all threads

  • Looks good and as described, thanks

    L2

  • mentioned in merge request !39028 (merged)

  • Edward Moyse mentioned in commit 95df2e0b

    mentioned in commit 95df2e0b

  • merged

  • mentioned in merge request !39165 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading