Porting online monitoring tool to use JetRecAlg

This is addressing ATR-22388 and ATR-22398

Some online monitoring histograms have been included in the legacy jet reconstruction driver, namely JetRecTool + JetAlgorithm. These histograms as well as the timing monitoring are now ported into JetRecAlg, which is what we want to use in the future.

Tagging @jbossios, @khoo

The test script @jbossios suggested returns 2020-12-08T154541 CET TrigValSteering INFO Test trig_mc_v1Dev_slice_jet_build finished with code 0 because all required steps were successful thus I think I didn't introduce any bugs or errors, at least.

For now, I have only included four basic timing monitors, similar to what was in JetRecTool, because I thought we could use that as a starting point and go from there.

The inclusion of the Monitoring Tool in the JetRecAlg python getter is slightly different wrt JetRecTool, but I think it should work that way, right @khoo ?

Hm, did you run the local unit tests? In particular the tests in JetRec and JetRecConfig should actually exercise the getJetRecAlg function. I'm wary of setting a ToolHandle to None.

The test suggested by @jbossios does not use getJetRecAlg at all, so while it would confirm that the C++ changes didn't break anything, it tells us nothing about the python.

You're right about the unit test, I'll check again

added 261 commits

• 2d4f4c07...d08d0375 - 259 commits from branch atlas:master
• c87be380 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into...
• 1943ed77 - Migrating old timers to Run3 Monitoring

Compare with previous version

The tests proposed here have all passed successfully, and I updated the timer monitoring to the MT version

added 251 commits

• 1943ed77...6f6a97cd - 250 commits from branch atlas:master
• 03840fd1 - pull master, update merge conflict

Compare with previous version

I got notified that a merge conflict was introduced, so had to update

resolved all threads

added 1 commit

• 563145f3 - Add timer readout for full modifiers loop

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• Reconstruction/Jet/JetRec
• Reconstruction/Jet/JetRecConfig

Affected files list will not be printed in this case

Adding @goetz as watcher

added JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result FAILURE (hash 563145f3)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25156]

added 121 commits

• 563145f3...198c1e90 - 119 commits from branch atlas:master
• 0228d010 - Pull from upstream/master to perform build tests
• 8b2d4a05 - Adding protection for AthGeneration

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetRec
• Reconstruction/Jet/JetRecConfig

Affected files list will not be printed in this case

Adding @goetz as watcher

CI Result SUCCESS (hash 8b2d4a05)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25217]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 15c97d73