Skip to content
Snippets Groups Projects

ATLASRECTS-5709 : Forward electron cluster cells

Merged ATLASRECTS-5709 : Forward electron cluster cells
ludovica/athena:forward_electron_cells into master
All threads resolved!
Merged Ludovica Aperio Bella requested to merge ludovica/athena:forward_electron_cells into master
All threads resolved!

MR closes ATLASRECTS-5709

Edited by Christos Anastopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christos Anastopoulos
  • Ludovica Aperio Bella added 15 commits

    added 15 commits

    Compare with previous version

  • Ludovica Aperio Bella
    Ludovica Aperio Bella @ludovica ·
    Author Developer

    Hi @christos

    what about now ?

  • Ludovica Aperio Bella added 1 commit

    added 1 commit

    • 9097c4a5 - RecExCommon_topOptions from MAster

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Reconstruction/RecExample/RecExCommon
    • Reconstruction/egamma/egammaAlgs
    • Reconstruction/egamma/egammaConfig
    • Reconstruction/egamma/egammaRec
    • Reconstruction/egamma/egammaTools

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • ATLAS Robot added Egamma Reconstruction master review-pending-level-1 labels

    added Egamma Reconstruction master review-pending-level-1 labels

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Reconstruction/RecExample/RecExCommon
    • Reconstruction/egamma/egammaAlgs
    • Reconstruction/egamma/egammaConfig
    • Reconstruction/egamma/egammaRec
    • Reconstruction/egamma/egammaTools

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Reconstruction/RecExample/RecExCommon
    • Reconstruction/egamma/egammaAlgs
    • Reconstruction/egamma/egammaConfig
    • Reconstruction/egamma/egammaRec
    • Reconstruction/egamma/egammaTools

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 8a12f74e)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25227]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 717ac19b)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25229]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 9097c4a5)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25231]

  • Ludovica Aperio Bella added 2 commits

    added 2 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Reconstruction/RecExample/RecExCommon
    • Reconstruction/egamma/egammaAlgs
    • Reconstruction/egamma/egammaConfig
    • Reconstruction/egamma/egammaRec
    • Reconstruction/egamma/egammaTools

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1b3fc9d7)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25294]

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Developer

    Hi

    Can you fix the following warning

    /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.cxx:163:12: warning: unused variable 'en' [-Wunused-variable]
       auto en = cluster->e()
  • Ludovica Aperio Bella added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • Reconstruction/RecExample/RecExCommon
    • Reconstruction/egamma/egammaAlgs
    • Reconstruction/egamma/egammaConfig
    • Reconstruction/egamma/egammaRec
    • Reconstruction/egamma/egammaTools

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 980d6a2f)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25315]

  • Pavol Strizenec
    Pavol Strizenec @pavol ·
    Developer

    Looks fine to me, approving...

    Pavol [as L2 MR shifter]

  • Pavol Strizenec added review-approved label

    added review-approved label

  • Pavol Strizenec removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Christos Anastopoulos changed title from Forward electron cells to ATLASRECTS-5709 : Forward electron cluster cells

    changed title from Forward electron cells to ATLASRECTS-5709 : Forward electron cluster cells

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit 0c31e2cf

    mentioned in commit 0c31e2cf

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply