[ATR-22206] Change InputMaker merging code to be typeless

This MR changes matchDecision from a templated function on the link CONTAINER type, to a typeless function which manipulates type data via the type's CLID.

This resolves a limitation where a user needing to use m_mergeUsingFeature could only do so if their slice's feature inherited from xAOD::IParticle. This limitation is now gone.

Note: I am getting a linker error against the typelessfindLinks function which I don't understand. Running CI to check if it's just me.

This merge request affects 1 package:

• Trigger/TrigSteer/DecisionHandling

This merge request affects 3 files:

• Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.h
• Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.icc
• Trigger/TrigSteer/DecisionHandling/src/InputMakerBase.cxx

Adding @tamartin as watcher

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 8c31c309)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 9
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25228]

added 1 commit

• 4d807e12 - Fix existing typo in typelessfindLinks

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigSteer/TrigCompositeUtils

Affected files list will not be printed in this case

Adding @tamartin as watcher

CI Result FAILURE (hash 4d807e12)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25318]

added 1 commit

• f7633b1e - Add deduplication checking to typelessFindLinks

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigSteer/TrigCompositeUtils

Affected files list will not be printed in this case

Adding @tamartin as watcher

CI failure due to the new-ish typelessFindLinks helper not performing de-duplication, like its typed counterpart does. In egamma, this resulted in a precisionCalo Decision Object resolving to the same initialRoI via two paths - the electron path, and the photon path. With de-duplication added, this second path doesn't contribute an additional entry to the return vector.

CI Result SUCCESS (hash f7633b1e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25367]

mentioned in merge request !39109 (merged)

Do not see any problem here, approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 53e7be43

added sweep:ignore label