HepMC3 nightlies branch fixes 16122020 part 1

In this MR:

• Use free functions for HepMC3 compatibility, e.g. HepMC::barcode
• Use c++11 loops
• Use GenParticle-> GenParticlePtr

changed title from HepMC3 nightlies branch fixes 16122020 part 1 to WIP HepMC3 nightlies branch fixes 16122020 part 1

This merge request affects 2 packages:

• Simulation/Tools/HitAnalysis
• Tracking/TrkTools/TrkTruthCreatorTools

Affected files list will not be printed in this case

Adding @jchapman ,@vpascuzz ,@amorley as watchers

added Simulation Tracking master review-pending-level-1 labels

Jenkins please retry a build

Jenkins please retry a build

changed title from WIP HepMC3 nightlies branch fixes 16122020 part 1 to HepMC3 nightlies branch fixes 16122020 part 1

changed title from HepMC3 nightlies branch fixes 16122020 part 1 to WIP HepMC3 nightlies branch fixes 16122020 part 1

CI Result FAILURE (hash ce37b4a4)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25308]

added 59 commits

• ce37b4a4...b9778595 - 57 commits from branch atlas:master
• 49c71ea4 - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_16122020_part_1
• 304e0fab - OK

Compare with previous version

This merge request affects 3 packages:

• Generators/AtlasHepMC
• Simulation/Tools/HitAnalysis
• Tracking/TrkTools/TrkTruthCreatorTools

Affected files list will not be printed in this case

Adding @jchapman ,@vpascuzz ,@amorley as watchers

added Generators label

CI Result SUCCESS (hash 304e0fab)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25335]

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

WIP and missing description.

added review-pending-level-1 label and removed review-user-action-required label

added review-user-action-required label and removed review-pending-level-1 label

marked as a Work In Progress

unmarked as a Work In Progress

changed title from Draft: WIP HepMC3 nightlies branch fixes 16122020 part 1 to HepMC3 nightlies branch fixes 16122020 part 1