Skip to content

Fix transforms for ITk ReadoutGeometry

Nicholas Styles requested to merge nstyles/athena:master-ReadoutGeometryITkCoordinateFix into master

For InnerDetector, m_transformHit and getMaterialGeom()->getAbsoluteTransform() are identical since SiHitToGeoModel() just returns the Identity transform.

For ITk this is not the case (we need to account for a slightly different convention when constructing the geometry), and we need to use the correct one in order to get sane positions for the Strip DetectorElements.

This MR corrects the transform used in the updateCache method. InnerDetector remains unchanged since the two options are identical (tested with RunTier0Tests.py), but ITk positions are (at least closer to) correct after this fix.

UPDATE: Following some checks, it seems centre positions of all ITk Strip modules agree with 21.9 after this fix, but some corrections are still needed for their tilt and stereo angles - to be followed up in a later MR.

Edited by Nicholas Styles

Merge request reports