Fix problems with ART tests in master, r 22

From @fwinkl :

m_athenaTool.typeAndName() != "IPythia8Custom"

But typeAndName() is probably "IPythia8Custom/IPythia8Custom". However, I recommend you change the code and use an empty ("") ToolHandle by default. Then simply check via

if (not m_athenaTool.empty()) ...

The code is clearly trying to create a tool of type IPythia8Custom, which itself is an abstract interface. This cannot work.

Thanks also to @ewelina.

G

This merge request affects 1 package:

• Generators/Pythia8_i

This merge request affects 1 file:

• Generators/Pythia8_i/src/Pythia8_i.cxx

added Generators master review-pending-level-1 labels

added 1 commit

• 0d32bf5f - removed old commented lines

Compare with previous version

This merge request affects 1 package:

• Generators/Pythia8_i

This merge request affects 1 file:

• Generators/Pythia8_i/src/Pythia8_i.cxx

added 1 commit

• 6d9f01b5 - removed old commented lines

Compare with previous version

This merge request affects 1 package:

• Generators/Pythia8_i

This merge request affects 1 file:

• Generators/Pythia8_i/src/Pythia8_i.cxx

CI Result SUCCESS (hash 0d32bf5f)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25465]

CI Result SUCCESS (hash 6d9f01b5)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25466]

CI Result SUCCESS (hash 8efbd675)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25461]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b57205f9

added sweep:ignore label