Add Condition Filtering to Fast Reduction

Jet Hypo. This MR allows leaf nodes in the the FastReduction Condition tree to have differing capacities. Condition dependent filtering (passing a subset of the original jet collection to a condition) is introduced.

HT chains are now run in FastReduction.

ATR-22533

@bossio @valente @khoo @peter

added master label

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @okumura ,@jpanduro as watchers

added JetEtmiss Trigger changes-trigger-counts review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A
required tests	N/A	N/A	N/A	N/A
optional tests	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25479]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @okumura ,@jpanduro as watchers

CI Result FAILURE (hash cdf24bc2)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25490]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @okumura ,@jpanduro as watchers

CI Result FAILURE (hash cdf24bc2)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25515]

added 1 commit

• a3bfade6 - Jet hypo, FastReducer - add collector guard in recordFiltering()

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @okumura ,@jpanduro as watchers

CI Result SUCCESS (hash a3bfade6)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25519]

This is a very large MR - so passing to L2.

The code seems good. My only comment is it looks like a major new bit of functionality is introduced, and I didn't see tests to cover it.

removed review-pending-level-1 label

added review-pending-level-2 label

Hi Gordon,

With regards to your comment on testing: all jet chains are affected, but no count changes occur, as is expected to be the case.

For all chains except the agg chains, (formerly HT), the changes are a rearrangement of existing code plus one new feature (filtering). For all but the agg chains, filtering is essentially a no-op.

For the agg chains however, filtering allows us to report participating jets as those which participate after filtering, which have not done until now. This functionality has been specifically requested.

Another important change is that leaf Condition nodes in the Conditions tree are no longer required to act on single jets. This means agg/HT chains can now run in FastReducer, whereas now they have been run outside FastReducer. In turn, this means agg/HT Conditions can be combined with other conditions, for example a dijet condition, which possibly will be a new chain request.

The fact that no chain counts change, combined with local small scale checks that the filtering in the case of HT is working as expected, provide an indication that the code is working as expected.

Thank you for your efforts.

Peter

Thanks for this MR @peter, and for addressing the questions that @gwatts raised (and that I would have as well). Given that you are one of the relevant experts here (indeed, the original author back in 2015 for some of these pieces of code) I'm happy to approve as L2.

added review-approved label and removed review-pending-level-2 label

merged