SGTools: Fix dummy proxy leak.

When we remove a proxy, be sure to decrement the reference count even if it's not in m_storeMap. A dummy proxy won't have been entered there, but it will still have gotten a reference count.

This merge request affects 1 package:

• Control/SGTools

This merge request affects 2 files:

• Control/SGTools/src/DataStore.cxx
• Control/SGTools/test/DataStore_test.cxx

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A
required tests	N/A	N/A	N/A	N/A
optional tests	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25538]

Jenkins please retry a build

This merge request affects 1 package:

• Control/SGTools

This merge request affects 2 files:

• Control/SGTools/src/DataStore.cxx
• Control/SGTools/test/DataStore_test.cxx

Adding @ssnyder as watcher

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A
required tests	N/A	N/A	N/A	N/A
optional tests	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25556]

Jenkins please retry a build

This merge request affects 1 package:

• Control/SGTools

This merge request affects 2 files:

• Control/SGTools/src/DataStore.cxx
• Control/SGTools/test/DataStore_test.cxx

Adding @ssnyder as watcher

marked as a Work In Progress

Seeing an ubsan warning that may be due to this.

CI Result SUCCESS (hash 010a2199)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25565]

• Title still marked WIP
• Changes seem straight forward, including a complete unit test (yes!)

(L1)

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• de8a9e97 - Need to do this a little differently: cant assume that we always have a...

Compare with previous version

unmarked as a Work In Progress

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 1 package:

• Control/SGTools

This merge request affects 2 files:

• Control/SGTools/src/DataStore.cxx
• Control/SGTools/test/DataStore_test.cxx

Adding @ssnyder as watcher

CI Result SUCCESS (hash de8a9e97)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25603]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0de70f73

added sweep:ignore label