TrigConfStorage: Fix memory leaks.
Fix a few memory leaks.
Edited by L2: Addresses ATR-20517
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigConfiguration/TrigConfStorage
This merge request affects 3 files:
- Trigger/TrigConfiguration/TrigConfStorage/src/L1TopoMenuLoader.cxx
- Trigger/TrigConfiguration/TrigConfStorage/src/LogicExpression.cxx
- Trigger/TrigConfiguration/TrigConfStorage/src/ThresholdConfigLoader.cxx
Adding @kwhalen ,@orlando ,@cmorenom ,@mark ,@asonay as watchers
added Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash c0b23d3a)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25539]removed review-pending-level-1 label
added review-pending-level-2 label
assigned to @ssnyder
- Resolved by Matthew Feickert
- Resolved by Matthew Feickert
Thanks for the MR @ssnyder. I agree with L1 @gwatts that this seems clean, but it would be good to get a small bit of clarification on the need for removal of the
TXC::L1TopoConfigGlobal
reference (if this could be updated in the MR body that would be great). To avoid slowing things down though I'll also escalate this to expert review and so if @kwhalen ,@orlando ,@cmorenom , @mark, @asonay have comments here I gladly welcome them.(L2)
added review-pending-expert label and removed review-pending-level-2 label
added review-approved label and removed review-pending-expert label
mentioned in commit eb617635
added sweep:ignore label