GPF MET

This MR affects METReconstruction and METUtilities.

In METReconstruction/METEgammaAssociator, links between PFO and egamma are implemented in the association Map. The association can be done either in the standard way (extractPFOs function) or using links (extractPFOsWithLinks function), depending on the flags usePFOPhotonLinks and usePFOElectronLinks, which are now set to False by default. Some initial setup towards using FlowElements links are included (also in METTau/MuonAssociator), but an "extractFEWithLinks" function has still not been implemented.

A new ORMETMakerAlg has been added in METUtilities, together with METReconstruction/RunORMETReco.py. This can be used for a MET reconstruction with JetTerm based on a new jet collection, with jets reconstructed including only PFOs not associated to other physical objects selected in MET. For this purpose, new functions (retrieveOverlapRemovedConstituents) is also added in the METMaker.

This merge request affects 3 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METReconstruction
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

added Egamma JetEtmiss Reconstruction Tau master review-pending-level-1 labels

CI Result FAILURE (hash d724970b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 3, warnings 31
AthAnalysis: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25634]

added 1 commit

• 189a95b3 - attempt to fix CMakeLists.txt in METUtilities & METInterface

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METReconstruction
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

CI Result FAILURE (hash 189a95b3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 3, warnings 21
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25647]

added 1 commit

• 978b89bb - attempt to fix compilation error in AnalysisBase

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METReconstruction
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

CI Result FAILURE (hash 978b89bb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 2
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25660]

Compilation error arising in METUtilities/Root/METMaker.cxx: error: base operand of '->' has non-pointer type 'SG::WriteHandle<DataVectorxAOD::PFO_v1 >'. Please address this error (http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G8AnalysisBaseOpt/NICOS_Log_MR-39381-2020-12-23-17-25/Reconstruction_MET_METUtilities.html)(L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 9e8ccf89 - fix compilation error in AnalysisBase

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METReconstruction
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 9e8ccf89)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 1, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25677]

added 1 commit

• f19dadfd - another small fix

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METReconstruction
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

CI Result SUCCESS (hash f19dadfd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25683]

There is a warning affecting the METUtilities package: warning: ignoring returned value of type 'StatusCode', declared with attribute nodiscard [-Wunused-result] app->finalize(); Could this be fixed? It seems related to this MR.

added review-user-action-required label and removed review-pending-level-1 label