DerivationFrameworkBPhys: Fix clang warnings.

• Unused private data member.
• Misleading operation ordering in conditional.
• Bugfix: misplaced parenthesis in abs() call.

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys

This merge request affects 3 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BPhysPVCascadeTools.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/BPhysVertexTrackBase.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/JpsiPlusDsCascade.cxx

Adding @wwalko ,@abarton as watchers

added Derivation master review-pending-level-1 labels

CI Result FAILURE (hash ff1006e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25785]

This looks like some filesystem problem during build, restarting.

Pavol [as L2 MR shifter]

Jenkins please retry a build

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys

This merge request affects 3 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BPhysPVCascadeTools.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/BPhysVertexTrackBase.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/JpsiPlusDsCascade.cxx

Adding @wwalko ,@abarton as watchers

CI Result SUCCESS (hash ff1006e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25801]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 40aba1a3

added sweep:ignore label