Adapt TauTruthMatchingTool for DAOD_PHYS

Adapt TauTruthMatchingTool for DAOD_PHYS, where truth matching is already present, mainly that IsTruthMatched is not present in the file. @ghamity, let me know if the fix is OK.

/cc @lheinric

added bugfix label

This merge request affects 1 package:

• PhysicsAnalysis/TauID/TauAnalysisTools

This merge request affects 2 files:

• PhysicsAnalysis/TauID/TauAnalysisTools/Root/TauTruthMatchingTool.cxx
• PhysicsAnalysis/TauID/TauAnalysisTools/test/ut_TauAnalysisTools_test.cxx

added Analysis Tau master review-pending-level-1 labels

Hi @tadej ,

I don't see a direct issue with this, though I would check with @martindl if we really want to bypass the IsTruthMatch check. I would expect it to be present for taus that are truth matched, so I guess this is pruned in DAOD_PHYS?

As truth links are there (although broken at the moment) I see no reason why also the matched flag would be there, but maybe I just do not understand tau code enough.

Hi @tadej and @ghamity ,

May I ask more details about the truth links that are broken? I was hoping they would be valid, as tau truth matching is performed in DAOD_PHYS, and the matching is made w.r.t. TruthTaus, TruthMuons, TruthElectrons, AntiKt4TruthDressedWZJets, which are all written out. We don't even rely on the addMiniTruthCollectionLinks relinking.

It's true that, while the TauJets smart slimming list provides truthParticleLink and truthJetLink, it is missing IsTruthMatched. Not sure if this was intended or not. I don't have much time to read the TAT code right now, maybe @cgrefe remembers.

There seems to be an issue with a lot of element links broken for tau. I guess it's because thinning is done after element links are decorated. I suppose @ghamity should know better about those issues in the analysis tools.

Is the thinning applied to the TRUTH3 mini collections?

You ask me too much here, but if I run the test I touched here, I still get invalid truth links with fairly recent DAOD_PHYS from master.

I know of tau track element link issues but now aware of broken truth match links, I would need to investigate this. Indeed never got a chance to test on DAOD_PHYS, could you send some instruction on how to run the unit test on the same DAOD_PHYS locally @tadej?

Indeed, I will add the patch to support tau track thinning in xAODTau shortly.

Just update ASG_TEST_FILE_MC with /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/ASG/DAOD_PHYS/v1/ttbar.FullSim.DAOD_PHYS.pool.root and run ctest -R TauAnalysisTools.

CI Result SUCCESS (hash 47f80dd9)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25802]

added review-user-action-required label and removed review-pending-level-1 label

Relabeling until the discussion is resolved. Magdalena (L1)

resolved all threads

I think this can be merged as is (and we can always revert it later if the contents of DAOD_PHYS change).

added review-pending-level-1 label and removed review-user-action-required label

added review-approved label and removed review-pending-level-1 label

merged