Skip to content

Coordinate fixes for ITk Strips

Nicholas Styles requested to merge nstyles/athena:master-fixITkAxisConvention into master

Several fixes to get the coordinate systems correct for ITk strips.

  • update coordinate definitions for HITS in InnerDetector/InDetG4/SCT_G4_SD/src/SctSensorGmxSD.cxx
  • Add dedicated stereo angle calculation for ITk Strip endcaps (built-in rotation needs different treatment) in InnerDetector/InDetDetDescr/InDetReadoutGeometry/src/SiDetectorElement.cxx
  • add radial shift to getExtent so that ITk Strip Endcaps are positioned correctly in DetectorDescription/ReadoutGeometryBase/src/SolidStateDetectorElementBase.cxx (required because Annuli have coordinate frame centred on beam line rather than sensor centre)
  • fix some pre-calculations of sin(+/-stereoAngle) so that signs are correct (do cos at same time for consistency, although it doesn't affect results) in InnerDetector/InDetDetDescr/SCT_ReadoutGeometry/src/StripStereoAnnulusDesign.cxx
  • Updates to allow ITk strips to be validated properly in InnerDetector/InDetExample/InDetDetDescrExample/src/ReadSiDetectorElements.cxx

Merge request reports