Remove default folder from SiDetectorManager

Remove default folder from SiDetectorManager. It seems to cause issues in some specific cases with dynamic alignment (e.g. data overlay).

Tagging potentially interested parties: @jchapman @amorley @nstyles

added bugfix label

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetReadoutGeometry

This merge request affects 1 file:

• InnerDetector/InDetDetDescr/InDetReadoutGeometry/src/SiDetectorManager.cxx

Adding @goetz ,@sroe as watchers

added ITk InnerDetector master labels

CI Result SUCCESS (hash c21e52c4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26083]

This is all green. @amorley, do you think this is safe to be merged. Would jobs anyways run without any alignment setup?

Hi @tadej,

I don't see a problem with this as the detector manager sets these thing up correctly. @nstyles does this require any change for ITK?

Anthony

Thanks Anthony! I already discussed with Nick and I think we're good to go from the ITk side. Will un-WIP the MR.

marked this merge request as ready

added alsoTargeting:21.0 label

added review-pending-level-1 label

Looks good. Approving.

Serhat (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7be144d0

added sweep:done label

picked the changes into the branch cherry-pick-7be144d0390-21.0 with commit 8652e274

mentioned in commit 8652e274

mentioned in merge request !39759 (merged)

Sweep summary
successful:

• 21.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1402/console for details)

mentioned in merge request !39786 (merged)

mentioned in commit 11672ee3

mentioned in merge request !41921 (merged)