Migrate LongLivedParticleDPDMaker to R22

This MR will migrate LongLivedParticleDPDMaker to R22 and add the relevant changes from 21p0 which were not swept to master before.

A validation test with 10k events was performed and results are here: https://cernbox.cern.ch/index.php/s/o1To0wjUoyCCtIG

All filters are working with the changes in this MR. There are some significant rate differences compared to R21p0 which still need to be understood.

Log files for the tests are located here: /afs/cern.ch/work/e/emily/public/validation_Feb15/ . There are a quite a few muon-related warnings when running with the master branch, and the muon software experts (@nkoehler, @rosati and @jojungge) have been informed.

Thanks to @goetz and @mhodgkin for your help with this.

Tagging @aroepe, @kpachal, @jmontejo, @calpigia, and @mdanning for info.

changed title from WIP: Master sweepfrom21p0 to WIP: Migrate LongLivedParticleDPDMaker to R22

added 1 commit

• 9128e285 - Remove unnecessary comments

Compare with previous version

added 4089 commits

• 9128e285...afc71d72 - 4088 commits from branch atlas:master
• 50b2d0eb - Merge branch 'master' into 'master-sweepfrom21p0'

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker

This merge request affects 43 files. Since this is a long list, it will not be printed.

Adding @hoide ,@cohm ,@aroepe ,@szambito ,@oabouzei ,@ykeisuke ,@jmontejo ,@leejr ,@emily as watchers

added Analysis Egamma JetEtmiss Tau Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 50b2d0eb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28251]

Added a few comments to resolve before approving -- L1

added review-user-action-required label and removed review-pending-level-1 label

added 6 commits

• e48c904a - Remove commented-out tau triggers
• 71ea8819 - Update copyright, add back VHFlags and TauFlags which were removed by conflict resolution
• df0f4db9 - Remove unnecessary pass statements
• 1a9663f1 - Remove outdated to-do's
• 13811f52 - Use std::abs
• db59bfb9 - Simplify for loops

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker

This merge request affects 65 files. Since this is a long list, it will not be printed.

Adding @hoide ,@cohm ,@aroepe ,@szambito ,@oabouzei ,@ykeisuke ,@jmontejo ,@leejr ,@emily as watchers

added review-pending-level-1 label and removed review-user-action-required label

Thanks @lgagnon for your careful review. I have addressed all of your comments.