Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !39716

Merged
Created Jan 14, 2021 by John Derek Chapman@jchapmanDeveloper

Make McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robust

  • Overview 10
  • Commits 2
  • Pipelines 2
  • Changes 2

This commit makes McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robust by:

  • checking all properties of the GenEvent.
  • GenVertex positions not at (0,0,0) to properly test TP conversion of those variables.
  • some double-precision properties are only stored with single-precision in the persistent version, so must be cast to float before being compared.

The current versions of McEventCollectionCnv_p5 and McEventCollectionCnv_p4 flip the order of the GenParticles associated with each GenVertex after T1->P1->T2 conversion. Running though this twice is sufficient to regain agreement (i.e. T1->P1->T2->P2->T3. T1 == T3 != T2).

Edited Jan 15, 2021 by John Derek Chapman
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ImproveMcEventCollectionTPCnvTest_21.0